Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move window plugin back to core #8007

Merged
merged 10 commits into from
Oct 17, 2023
Merged

feat: move window plugin back to core #8007

merged 10 commits into from
Oct 17, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Oct 11, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner October 11, 2023 19:30
@amrbashir amrbashir marked this pull request as draft October 11, 2023 19:43
@amrbashir amrbashir marked this pull request as ready for review October 11, 2023 20:10
@amrbashir
Copy link
Member Author

I will move the app plugin in another PR

@lucasfernog lucasfernog merged commit c9a9246 into dev Oct 17, 2023
19 of 29 checks passed
@lucasfernog lucasfernog deleted the feat/window-plugin branch October 17, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog